Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused graphql fields #1448

Merged
merged 22 commits into from
Feb 13, 2025

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Feb 6, 2025

Reasoning

Proposed Changes

How to test

Copy link

github-actions bot commented Feb 6, 2025

k6 load testing comparison.
Base Commit Hash: 56d6741
Target Commit Hash: 375ff93

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex48.77553.7653.2355.1547.33244.7051.6053.33-2.97% ✅-55.81% ✅-3.06% ✅-3.31% ✅
Nodes48.64260.7653.2055.1347.49333.2151.6153.31-2.35% ✅+27.79% 🔴-3.00% ✅-3.31% ✅
Accounts50.061135.9853.1054.9948.27903.6751.5653.36-3.58% ✅-20.45% ✅-2.89% ✅-2.96% ✅
Tokens49.41701.6153.2655.0847.85708.4751.6353.37-3.15% ✅+0.98% 🔴-3.07% ✅-3.11% ✅
Transactions63.182697.0853.7957.1262.342902.5652.4454.59-1.33% ✅+7.62% 🔴-2.50% ✅-4.43% ✅
Blocks55.611366.5253.7157.7155.121309.1652.0854.41-0.88% ✅-4.20% ✅-3.03% ✅-5.72% ✅
Pool49.38667.9653.2555.1047.88683.2651.7253.41-3.04% ✅+2.29% 🔴-2.87% ✅-3.06% ✅
Test Run Duration60001.9060005.38

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

claudiulataretu
claudiulataretu previously approved these changes Feb 7, 2025
@bogdan-rosianu bogdan-rosianu self-requested a review February 7, 2025 11:44
src/common/graphql/graphql.service.ts Show resolved Hide resolved
const filteredPairs = this.applyFilters(mexPairs, filter);

return filteredPairs.length;
}

async getAllMexPairsRaw(): Promise<MexPair[]> {
async getAllMexPairsRaw(includeFarms: boolean = false): Promise<MexPair[]> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we create a new class MexPairsOptions or MexPairsFilter that will contain the includeFarms field? Passing a boolean to a function is not the best practice

src/endpoints/mex/mex.settings.service.ts Outdated Show resolved Hide resolved
@cfaur09 cfaur09 self-assigned this Feb 8, 2025
@cfaur09 cfaur09 added refactoring The same functionality is maintained, but in an improved way performance Performance improvement labels Feb 8, 2025
@dragos-rebegea dragos-rebegea merged commit 6e3b838 into development Feb 13, 2025
6 checks passed
@dragos-rebegea dragos-rebegea deleted the API-452-remove-unused-graphql-fields branch February 13, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement refactoring The same functionality is maintained, but in an improved way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants